Giuseppe
Giuseppe
That sounds great!! We'd like to take part in the discussion, let me know when it will be, thanks!!
@tdonohue your feedback should be addressed. Please mind for the third point you should update also the REST branch to properly check it
@tdonohue fixed
@tdonohue merge conflicts resolved
@tdonohue @benbosman this PR is ready to be reviewed, all issues with [angular PR](https://github.com/DSpace/dspace-angular/pull/1818) are resolved. Thanks
Actually the maximum number of pages to display for the pagination component is not setted, but we could set a default value. However both the implementation you've proposed can be...
@tdonohue @artlowel regarding the CodeQL alert, i've added some checks how is described in the documentation but it persists. Do you have any suggestion, could we ignore it or do...
thanks @artlowel for suggestions, now every checks pass and PR is to be reviewed
@tdonohue @paulo-graca the PR is ready to be review. thanks
@tdonohue I think we can fix in this PR @YanaDePauw it's just enough to remove the `flex-wrap` here https://github.com/atmire/dspace-angular/blob/w2p-94390_replace-dso-page-edit-buttons-with-a-menu/src/app/shared/dso-page/dso-edit-menu/dso-edit-menu.component.html#L1 and here the result 