dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Enrich local data via the OpenAIRE Graph

Open LucaGiamminonni opened this issue 3 years ago • 7 comments

References

  • Related to https://github.com/DSpace/RestContract/pull/181
  • Related to https://github.com/DSpace/DSpace/pull/8184

Description

The features included in this PR are the result of the OpenAIRE Call Innovation funded project "Enrich local data via the OpenAIRE Graph” awarded by 4Science (https://www.openaire.eu/open-call-winner-phase-1-4science). It provides a closer integration between DSpace and two OpenAIRE services, the Notification Broker and the OpenAIRE REST API. Detailed documentation about the aims of the project, the implementation and the configuration options is available at https://4science.github.io/oaire-eld/#/ This PR regarding only the data correction section. The publication claim will be migrated with other PR.

LucaGiamminonni avatar Mar 17 '22 16:03 LucaGiamminonni

This pull request introduces 5 alerts when merging a4718b60869fa28497d8cffdbc3abad0d8fd2cd8 into 3ecb3c220965f187832ee8a868f3c5ead29f56b6 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Mar 17 '22 16:03 lgtm-com[bot]

Moving this PR to 7.4 as it won't be possible to review/approve in time for 7.3. We'll instead work to get this merged just after the 7.3 release.

tdonohue avatar Jun 08 '22 15:06 tdonohue

This pull request introduces 6 alerts when merging a7d2278d993212d60cb8c43fdfe1da000d6f3e5c into fae355a71372d6f3ab25e699d3e69671a5b68124 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 06 '22 15:07 lgtm-com[bot]

This pull request introduces 5 alerts when merging 530db26587b4faada51a961980f1beea06fdc681 into fae355a71372d6f3ab25e699d3e69671a5b68124 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 06 '22 16:07 lgtm-com[bot]

This pull request introduces 5 alerts when merging 0942a1e474b4751256421450af327338191106e1 into fae355a71372d6f3ab25e699d3e69671a5b68124 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 07 '22 15:07 lgtm-com[bot]

This pull request introduces 5 alerts when merging bb357df738ce12c35064434f5663de2932f53546 into fae355a71372d6f3ab25e699d3e69671a5b68124 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 08 '22 16:07 lgtm-com[bot]

This pull request introduces 5 alerts when merging 7808f85a2dea85b347c6bf64531577c5fdce0851 into fae355a71372d6f3ab25e699d3e69671a5b68124 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 08 '22 16:07 lgtm-com[bot]

Hi @LucaGiamminonni, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Nov 03 '22 16:11 github-actions[bot]

This pull request introduces 5 alerts when merging 3a70b880cbc41b32521d4251e7e912e9bb27b6d8 into 89447a6c32ee1fd28d9f2c5e523becdb8622d734 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Nov 09 '22 14:11 lgtm-com[bot]

This pull request introduces 4 alerts when merging 5efe3296c613be48d25251bfbfdd24e3d448556c into 89447a6c32ee1fd28d9f2c5e523becdb8622d734 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

lgtm-com[bot] avatar Nov 09 '22 18:11 lgtm-com[bot]

This pull request introduces 3 alerts when merging 79cd69fb9421d818b9e33731fc8eb2e47f49f3c7 into 89447a6c32ee1fd28d9f2c5e523becdb8622d734 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

lgtm-com[bot] avatar Nov 11 '22 12:11 lgtm-com[bot]

@tdonohue @paulo-graca the PR is ready to be review. thanks

atarix83 avatar Nov 11 '22 13:11 atarix83

Hi @LucaGiamminonni, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Jan 18 '23 17:01 github-actions[bot]

Hi @LucaGiamminonni, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Feb 02 '23 16:02 github-actions[bot]

@frabacche : This appears to have 3 lint errors after the recent updates. Run yarn lint locally to see them. You may also be able to run yarn lint --fix to try to fix them automatically (doesn't always work).

In the meantime, I'll give it a test in the next few hours and verify everything looks good.

tdonohue avatar Dec 18 '23 16:12 tdonohue

Merging, as this has a +1 from myself, and a prior +1 from @paulo-graca . I've also verified that all of @paulo-graca 's feedback appears to be addressed except for the themed components. But those can be added in later PRs

Thanks again to @frabacche , @FrancescoMolinaro , @LucaGiamminonni and the entire 4Science team for their hard work on this new feature!

tdonohue avatar Dec 18 '23 19:12 tdonohue