Andrew Aquino

Results 24 issues of Andrew Aquino

I moved a function written by @httpNick in client.js to client.coffee. Similarly, I moved the findListingByIds function by @gsabran from search.js to search.coffee. To prevent issues like these in the...

resolves #5526, closes #5735 Thank you for making the original PR @jawahars16 and @DanielJGeiger! I rebased it onto master and added tests as @ad1992 requested. Also refactors some existing selection...

custom objects like notes, measures, and durations are unwieldy

especially modals e.g., - [react-aria-components](https://react-spectrum.adobe.com/react-aria/react-aria-components.html) - [reach-ui](https://reach.tech/) - [radix-ui](https://www.radix-ui.com/primitives)

Action definitions account for almost half of App.jsx's length: https://github.com/aqandrew/fret-zone/blob/4612f11ed787533644d0785f9a6ea9d09fb608e6/src/App.jsx#L70-L511 These can live in a custom hook instead: https://stackoverflow.com/questions/59556939/reactjs-create-a-separate-file-for-functions-that-dispatch-actions

PNG spritesheet or individual SVGs? What are the pros and cons of each?

`useRef` is better for keeping track of a variable like this.

- [tinykeys](https://jamiebuilds.github.io/tinykeys/) will probably make this clean - Supports cross-platform keybinding with `$mod`!

enhancement

A menu bar is probably a wheel that doesn't need to be reinvented: ![image](https://user-images.githubusercontent.com/9038965/86413879-3dab7b80-bc77-11ea-852c-e309ff7b13dc.png)

enhancement