Andrew Aquino
Andrew Aquino
Hmmm the 10 failing tests occur in resize.test.tsx. Any clue why that's happening if those tests don't hit the escape key?
Possibly related: this change breaks the expected behavior of `LinearElementEditor` (now esc doesn't finish creating a line/arrow--only enter does) https://github.com/excalidraw/excalidraw/assets/9038965/ec8c2c0f-83d6-401f-b949-3f21a8db530f Will fix this!
The failing tests and bug from the video above are now fixed. 🙂 Could you please review @dwelle?
> Hmmm the 10 failing tests occur in resize.test.tsx. Any clue why that's happening if those tests don't hit the escape key? For future reference / anyone curious: Those tests...
Sure. In reducers.js, there are some object definitions that represent tracks, measures, durations, and notes: https://github.com/aqandrew/fret-zone/blob/423cf947261b1935872447d47b1bc7986a0bda2c/src/reducers.js#L3-L44 I'd like to add TypeScript to this project so that I can have more...
Please don't do that. For the time being this is just an educational project for myself, so I'm not accepting unsolicited PRs
SMuFL provides a way to map from musical notation to Unicode: https://w3c.github.io/smufl/gitbook/ https://github.com/steinbergmedia/bravura
Hi! I've written frontend tests for a couple of my projects: - [here](https://github.com/aqandrew/baybayin/tree/main/__tests__) I wrote unit tests from the beginning - [here](https://github.com/aqandrew/fret-zone/tree/main/src/tests) I added integration tests to an existing project...
@ryanfchase Sounds good! Just a couple more notes worth mentioning--want to leave a paper trail of this info: - [x] We should add another action item for setting up CI...
>I’m thinking about starting an issue to jot down every time someone provides information that should go in a wiki. Good idea! Though I think we can live without this...