Apoorve Dave

Results 15 comments of Apoorve Dave

Thanks @rapoth , yeah I will fix it before merging. the general idea is we will have lot's of approved simplified plans for different configs. Just as an example, with...

@imback82 @pirz @thugsatbay @sezruby please take a look at the latest changes for gold standard

Note to reviewers: Tests for delete scenarios have not been added yet. Please have a look for general idea and comments. Nit comments are ok but not necessary at this...

> Could you simply measure and share the performance described in "Success criteria" in #233 before moving forward? > > I think the only gain is not performing `listFiles` for...

cc @imback82 @thugsatbay @AFFogarty @sezruby please have a look at the updates incorporated after discussion

> Question: is there any case that JoinRule v2 cannot cover but JoinRule v1 can? Could we replace v1 with v2? V1 rule works on both sides of a join...

note to reviewers: There is one issue currently with this pr: when running an individual query against approved files, the tests fail. When running all queries at the same time,...

> @apoorvedave1 Could you create a PR with just *.scala and one query set? Thanks @imback82 , working on https://github.com/microsoft/hyperspace/pull/377 for the suggestion

Note to reviewers, currently q49 doesn't work well with the build pipelines so as per offline suggestions I have removed it from this PR. I will add it back once...

> @apoorvedave1 Could you do this? > > 1. Take resource files from OSS Spark and create a PR, and we will just merge quickly. > 2. Rebase this PR....