hyperspace icon indicating copy to clipboard operation
hyperspace copied to clipboard

Gold Standard: spark-only version for creating and comparing golden files

Open apoorvedave1 opened this issue 5 years ago • 3 comments

What is the context for this pull request?

Gold standard for non-hyperspace plan stability suite

Parent Issue: #334

What changes were proposed in this pull request?

Gold standard for non-hyperspace plan stability suite (vanilla spark version)

Does this PR introduce any user-facing change?

no

How was this patch tested?

unit tests

apoorvedave1 avatar Feb 19 '21 18:02 apoorvedave1

note to reviewers: There is one issue currently with this pr: when running an individual query against approved files, the tests fail. When running all queries at the same time, the tests pass. I haven't yet fixed this issue.

apoorvedave1 avatar Feb 19 '21 18:02 apoorvedave1

@apoorvedave1 Could you create a PR with just *.scala and one query set?

Thanks @imback82 , working on https://github.com/microsoft/hyperspace/pull/377 for the suggestion

apoorvedave1 avatar Mar 10 '21 18:03 apoorvedave1

Thanks!

imback82 avatar Mar 10 '21 19:03 imback82