Aliya Pazylbekova

There are currently a lot of ways to create a render pass: RenderPass - RenderPassCreateInfo - RTVs and/or DSV exist (swapchain, graphics benchmark) - RenderPassCreateInfo2 - will create images and...

ClearRenderTarget/ClearDepthStencil don't work with dynamic render passes

1

This is a follow up from https://github.com/google/bigwheels/pull/356 ClearRenderTarget/ClearDepthStencil (https://github.com/google/bigwheels/blob/b0bded04e4fc17048443ee4ef74507a2e6a942f2/src/ppx/grfx/vk/vk_command.cpp#L289) accept an image and clear an image while inside a render pass. The functions use current render pass variable to figure...

Remove the need for PPX_BUILD_XR in project level code

1

For example in graphics benchmark app: https://github.com/google/bigwheels/blob/main/benchmarks/graphics_pipeline/GraphicsBenchmarkApp.cpp having to add PPX_BUILD_XR complicates code unnecessarily. We should define the XR functions with or without PPX_BUILD_XR and make sure they behave appropriately...

For example here https://github.com/google/bigwheels/blob/974b677a238e5c36c5ff4ee7efdbc949c010586e/include/ppx/profiler.h#L96 and related code. This was added a long time ago, and is very likely not useful since there should be better ways to do this.

Not for submission, some thought experiments

1

- There is a bit of a weird relationship between settings and default values for things that repeat: resolution and XR UI resolution. If the defaults for those are provided...

Some other samples (https://github.com/SaschaWillems/Vulkan/blob/master/examples/pushconstants/pushconstants.cpp) using push constants are able to run on SwiftShader. The size used is below the device limit advertised, so that shouldn't be a problem.

GPU mipmap generation broken when running with SwiftShader

1

Step 1: enable swiftshader https://github.com/google/bigwheels/blob/main/docs/software_rendering.md Step 2: run a sample for example: 05_cube_textured or to see more clearly: run vk_27_mipmap_demo, select a different mip level (> 0) to be generated...

Currently all extensions that can be enabled are enabled.

Update C++ style guide reference

1

The [contributing](https://github.com/google/bigwheels/blob/main/CONTRIBUTING.md#for-developers-contributing-a-patch) page advises contributors to make sure that the code "follows the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html)." We currently don't follow the Google style guide. We should probably remove the...

Add README for projects that are currently without (fishtornado, 28_gltf)

2

It seems like fishtornado(xr) and 28_gltf projects currently don't have a README. It might be useful to add, particularly to document additional command line arguments such as the ones added...