bigwheels icon indicating copy to clipboard operation
bigwheels copied to clipboard

Not for submission, some thought experiments

Open apazylbe opened this issue 2 years ago • 1 comments

  • There is a bit of a weird relationship between settings and default values for things that repeat: resolution and XR UI resolution. If the defaults for those are provided then the values in the settings will be overwritten. Might not be a problem, but might not be immediately obvious.

  • There is an ordering dependencies between some functions in the beginning of Run(). They seem to be documented, but comments don't seem to be the best way for this, as some comments already might cause confusion. This explores the option of providing defaults in the InitKnobs instead of as part of the settings.

  • Removing the storage for the flags in command line parser, this seems to be only needed for --help, so it shouldn't be necessary to store that.

apazylbe avatar Nov 28 '23 03:11 apazylbe

I'll add a bit more to the resolution mess

To obtain the resolution to render:

  • Application::GetWindow{Width,Height}(), use mSettings.window.{width,height}
  • GetSwapchain()->GetColorImage(i)->GetWidth() (04_cube), uses image parameter
  • GetSwapchain()->GetWidth() (22_image_filter), uses swapchain parameter

To get the viewport

  • Application::GetViewport(), use mSettings.window.{width,height}
  • GetSwapchain()->GetRenderPass()->GetGetViewport() (21_text_draw), uses renderpass parameter

hysw avatar Nov 28 '23 22:11 hysw