Anton Vlasenko

Results 14 comments of Anton Vlasenko

> Note: echo sprintf() in itself already is a little nonsensical as that should be replaced with a call to printf(). Thank you for the quick reply, @jrfnl . This...

Thank you for your response, @jrfnl. > It also changes the focus of the feature request away from "performance" to "coding error". From my point of view, the second code...

> That is not something for PHPCS to safeguard against, as PHPCS cannot determine that arbitrary user provided input is being used. This is something which should have been caught...

@hellofromtonya Thank you for the thorough review! I've replied to your comments, and I’m happy to provide any further clarification or updates if needed. Please let me know if you’d...

~~This PR needs additional investigation/research since the unit tests are failing.~~ I think the PR is in good shape now and can be reviewed. I will add the reasoning to...

> > Could the test file be renamed to `renderBlockCorePostTitle.php`? > > Is this the new standards that we are going to follow from now on for test file name?...

> For the sake of discussion, let's presume the OP meant to limit the ticket to the magic __get()/__isset()/__set()/__unset() methods. This made me rethink what I actually meant. I will...

> Introducing a "getter" method, will, depending on the size of the class and the number of properties this applies to, litter the class with dozens of extra methods, which...

@Mamaduka If the only reason to disable autosaving is this warning message, I propose waiting until the core fix is merged rather than disabling autosaving (fixing these endpoints shouldn't take...

@Zodiac1978 I believe this syntax can be used to match newline characters: `first_string(?s).+second_string`. And yes, I realize this issue was opened 4 years ago.