wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Fix `WP_Term::$data` dynamic property

Open anton-vlasenko opened this issue 1 year ago • 4 comments

Trac ticket: https://core.trac.wordpress.org/ticket/58087


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

anton-vlasenko avatar Apr 22 '24 14:04 anton-vlasenko

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Apr 22 '24 14:04 github-actions[bot]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @rockitround.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props antonvlasenko, hellofromtonya.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Apr 23 '24 16:04 github-actions[bot]

~~This PR needs additional investigation/research since the unit tests are failing.~~

I think the PR is in good shape now and can be reviewed. I will add the reasoning to the trac ticket soon.

anton-vlasenko avatar Apr 23 '24 18:04 anton-vlasenko

have considered several possible solutions to the issue with WP_Term::$data. Explicitly declaring the $data property and initializing it in the class constructor. {{{ #!html }}}

rockitround avatar Apr 26 '24 04:04 rockitround