antmarzam

Results 21 comments of antmarzam

@martin-velay Thanks a lot for putting this together! I've left a few comments, but overall it feels this PR is taking things on the right direction. The only thing I'm...

I run the command: ``` ../../mig_pr_review.py --source-branch integrated_dev --target-branch master --migration-branch Razer6/soc-proxy-sync-to-master --path hw/top_darjeeling/ip/soc_proxy --show-diff=: | tee darjeeling_dif ``` List of commits which missed porting information: 1. [[hw/top_darjeeling] Add scaffold...

@Razer6 / @andreaskurth I just went through the entire dif. I've updated the comment [above](https://github.com/lowRISC/opentitan/pull/24442#issuecomment-2368364128)

I just went again through the diff after pulling the latest changes and I believe my diff comment above ([here](https://github.com/lowRISC/opentitan/pull/24442#issuecomment-2368364128)) still stand.

> > I just went again through the diff after pulling the latest changes and I believe my diff comment above ([here](https://github.com/lowRISC/opentitan/pull/24442#issuecomment-2368364128)) still stand. > > @antmarzam What exactly are...

The PR looks good - happy to get it merged. I'm just copy-pasting down-here the post-merge action item list so it's not forgotten: ### Post merge Action items: - Check...

# Commits since AON TIMER D2(S) Signoff (#20995 ) `git rev-parse HEAD` 83e259f87ca1079497f9714a17efe0ce9a28e622 `git log f4ed82cc92dcb97ddcb5208ff3350461551b682b..HEAD --oneline hw/ip/aon_timer/` Note: All the commits which are TB related only have been pulled...

> An additional commit has been made since [the D2S..D3 review](https://github.com/lowRISC/opentitan/issues/22632#issuecomment-2743545894), which adds RACL to AON timer: [88a1846](https://github.com/lowRISC/opentitan/commit/88a1846d085b93f5554e4f085254905b7b42f64f) Thank you Marno! I've cleaned up and updated the commit list now...

> I think you've mentioned a different commit than I have. Your commit does affect the core file but not the RTL which the one I reference does affect. Do...

All the items which needed doing have now been addressed by PRs: #26806 #26804 #26805 Plus @marnovandermaas has done an RTL review in #26902 The PR to bump up the...