Anthony D'Atri comments

Results 100 comments of


                                            Anthony D'Atri

Update README.md

Given the conflict, I suggest abandoning and resubmitting for clarity.

WIP: doc/dev: add explanation of how to use deduplication

Please amend the PR and commit descriptions with the preferred format beginning with the full relative directory, in this case something like: `doc/dev: Add explanation of how to use deduplication`

WIP: doc/dev: add explanation of how to use deduplication

> warning Very good point.

Rook 1.9.7 toolbox version

Thanks! I'm quite experienced with Ceph but new to Rook and K8S. Any prediction for when 1.10 might drop?

Rook 1.9.7 toolbox version

Thanks! In our case we'll wait for 1.10, this will be a good test case for upgrading Rook before we get to real production.

docs: add additional RBD image features to docs and YAML files

I believe my latest push addresses the latest comments.

docs: add additional RBD image features to docs and YAML files

My thoughts were to not implicitly require 5.4+, but also to not be held back by older. If you've ever run `rbd du` on a 16TB RBD volume you'll understand...

docs: add additional RBD image features to docs and YAML files

The failed unit doesn't _look_ like it is related to this change

docs: add additional RBD image features to docs and YAML files

@Rakshith-R @travisn the failed tests appear to be unrelated to these changes

docs: add additional RBD image features to docs and YAML files

@travisn Still dealing with cross-country move fallout. Thought I had to rebase, which I admittedly have never managed successfully - I always end up dragging in a thousand unrelated commits....