ceph icon indicating copy to clipboard operation
ceph copied to clipboard

WIP: doc/dev: add explanation of how to use deduplication

Open myoungwon opened this issue 3 years ago • 3 comments

Signed-off-by: Myoungwon Oh [email protected]

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • [ ] References tracker ticket
    • [ ] Very recent bug; references commit where it was introduced
    • [ ] New feature (ticket optional)
    • [ ] Doc update (no ticket needed)
    • [ ] Code cleanup (no ticket needed)
  • Component impact
    • [ ] Affects Dashboard, opened tracker ticket
    • [ ] Affects Orchestrator, opened tracker ticket
    • [ ] No impact that needs to be tracked
  • Documentation (select at least one)
    • [ ] Updates relevant documentation
    • [ ] No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

myoungwon avatar Apr 29 '22 06:04 myoungwon

Please amend the PR and commit descriptions with the preferred format beginning with the full relative directory, in this case something like:

doc/dev: Add explanation of how to use deduplication

anthonyeleven avatar Apr 29 '22 06:04 anthonyeleven

Add a warning at the top that this feature is highly experimental and is subject to change or removal.

athanatos avatar May 04 '22 21:05 athanatos

warning

Very good point.

anthonyeleven avatar May 04 '22 21:05 anthonyeleven

@athanatos Can you take a look?

myoungwon avatar Oct 20 '22 01:10 myoungwon

@myoungwon: The "pull request checklist" wasn't filled out, which was preventing this PR from being mergeable.

I've filled out the checklist, and will now merge and backport this PR.

zdover23 avatar Oct 20 '22 15:10 zdover23

https://github.com/ceph/ceph/pull/48567 - Quincy backport https://github.com/ceph/ceph/pull/48568 - Pacific backport

zdover23 avatar Oct 20 '22 16:10 zdover23

@zdover23 This probably shouldn't be backported.

athanatos avatar Oct 20 '22 16:10 athanatos

@zdover23 This probably shouldn't be backported.

@athanatos: I'll create a couple of new PRs that take this feature out, since you're the architect of this thing and the authority on it. I acted here (wrongly, as it turns out) after consulting an email to [email protected] on 16 Apr 2020 with the subject line "CDS Pacific highlights - RADOS", which suggested to me (again, wrongly, which is totally on me) that this feature would be new in Pacific.

In short: sorry about that.

zdover23 avatar Oct 20 '22 16:10 zdover23

@athanatos: Is deduplication expected to land in Reef?

zdover23 avatar Oct 20 '22 16:10 zdover23

https://github.com/ceph/ceph/pull/48570 - Quincy backport reversion

zdover23 avatar Oct 20 '22 16:10 zdover23

https://github.com/ceph/ceph/pull/48571 - Pacific backport reversion

zdover23 avatar Oct 20 '22 17:10 zdover23

@zdover23 No worries, thanks!

athanatos avatar Oct 20 '22 17:10 athanatos