Anthony Bilinski

How to safely call hook_stop not from a callback?

6

Since `hook_run` blocks the thread until stop is called, the only places `hook_stop` can be called on the same thread are in callbacks, which is what the two demos do....

Setup being done on library load that requires display to be present

3

If being run in a headless environment, e.g. through ssh or with an application that's being unit tested on a CI server, libuiohook causes a segfault during library load: ```...

Run clang-tidy and clang-format in CI

1

This is mostly a note to myself since I've had two people tell me to add this today and I don't have time to do it right now. We have...

WIP Friend blocking

1

TODO: * Finish splitting history * Reorder history so that each commit in order is functional or at least doesn't expose broken parts to the user. * Fix ChatLog races...

qTox hangs when clicking the file transfer button

4

##### Brief Description OS: Arch 2022-02-20 qTox version: v1.17.4+ Commit hash: d19ae1ead0db730a800af1e24a7683ca5a08bd79 toxcore: 0.2.16 Qt: 5.15.2 Reproducible: Always (within one run, haven't seen it previously) ##### Steps to reproduce 1....

Unit test SQLCipher handling code

3

We've had a couple issues with SQLCipher handling code #5451, #5952. The first fix #5726 missed a case that needed to be fixed in #6084. We now have 3 possible...

##### Brief Description OS: Ubuntu 18.04 qTox version: v1.17.6+ Commit hash: f777aa885cde638167c96792647726fc65d096ae toxcore: 0.2.17 Reproducible: Always ##### Steps to reproduce 1. Build toxcore in static mode. 2. Build any qTox's...

In CMakeLists, we've checked `brew --prefix qt5` since the introduction of cmake: https://github.com/qTox/qTox/blob/bc751c8e1cac455f9690654fcfe0f560d2d7dfdd/CMakeLists.txt#L64 But configuring with cmake from source recently still requires manually specifying `-DCMAKE_PREFIX_PATH="$(brew --prefix qt5)"`. It's unclear if...

Chatlog sometimes gets stuck blank since refactor

1

##### Brief Description OS: Arch Linux qTox version: v1.17.4 Commit hash: 65c42ebd9e2cbc5addab2f1f2502c2e1d5022a8e toxcore: v0.2.13 Qt: 5.15.2 Reproducible: Rarely Maybe once every few hours of typing in a conversation with pages...

Sqlcipher default params can change in minor releases which can reduce security guarantees (https://github.com/qTox/qTox/pull/6416#issuecomment-987760832), or in major releases break compatibility with existing database files (https://github.com/qTox/qTox/issues/5952). We should explicit set all...