Anthony Bilinski

Results 69 comments of Anthony Bilinski

> Calling hook_stop directly from the callback should be fine as it just unregisteres the hook and shouldn't have any thread safety issues. My issue with this approach is that...

> Your going to need some event somewhere to decide when to call the function ;) Either the user event though the hook callback, an event timer, or via the...

I was thinking that on library load libuiohook could not touch anything that required display, and all that could be done in `hook_run` or something like `hook_init`. Then even though...

We should also check git commit formatting more completely, i.e. line length and possibly spelling? Though spelling might be hard to enforce strictly due to tox-specific or technical words.

@sudden6 I think so. The bug is very likely within these few lines https://github.com/qTox/qTox/blob/412f14558150e4da76acb3d639f5a23dca58b33b/src/video/genericnetcamview.cpp#L134, and might be solvable with a little reading of Qt docs and investigation.

My previous comment saying that this issue is likely trivial was wrong, some investigation has gone into it but it's not clear what we're doing wrong. Even though this is...

I'll take another look at it and see if I can make some progress.

To upgrade you should download the installer from https://github.com/qTox/qTox/releases/tag/v1.17.6 i.e. [setup-qtox-x86_64-release.exe](https://github.com/qTox/qTox/releases/download/v1.17.6/setup-qtox-x86_64-release.exe), close the running qTox, then run the installer. If that's giving you errors, please open a new issue since...

The logs look normal, and our notification sound if shorter than the time between us opening and closing the output device there, which makes sense. I'm not able to reproduce...

I haven't seen this in a couple weeks - probably a fleeting dep issue like I thought. Will keep my eye out for a couple more weeks, but if I...