Andrew Liebenow

Results 22 comments of Andrew Liebenow

> Review looks OK. > > In regards to testing, does the `-s` output match BSD or Linux diff? I'm not sure what the difference is, and some searching didn't...

Old: ``` ---- tr::tr_octal_above_one_byte_value stdout ---- thread 'tr::tr_octal_above_one_byte_value' panicked at plib/src/testing.rs:85:5: assertion `left == right` failed left: "(Ł)" right: "Ł)" note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace...

The new format might look a bit verbose, but I've repeatedly run up against: 1) Not remembering what left/right correspond to (actual/expected) 2) Not knowing if the comparison is in...

See https://git.musl-libc.org/cgit/musl/tree/include/utmpx.h?h=v1.1.24. I'm not sure if adding these constants would be considered a breaking change (https://doc.rust-lang.org/cargo/reference/semver.html#item-new).

Added an additional change to prevent `grep` from aborting/failing when the input contains non-UTF-8 bytes

I ran into a build script that was trying to use `-o`. I can't remember which program it was I was compiling, I'll try to find it. Most of the...

I couldn't find the program I had been trying to compile, but here's an interesting statistic: I have a directory containing 42 Git repositories I've cloned. 4 of those repositories...

https://github.com/uutils/coreutils/pull/6803 should fix this. I went with a simpler fix. Since everything is being printed to stdout, which is obviously not restricted to UTF-8 data, the escape codes can just...

A nice way to debug these issues is to use `bat -A`: ``` ❯ echo -e '\xf0\x41\x9f\x98\x82' | bat -A ───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── │ STDIN ───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 1 │ \xF0A\x9F\x98\x82␊ ───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── ``` https://github.com/sharkdp/bat...

Partly resolves the last issue listed in https://github.com/uutils/coreutils/issues/6777. I'm not sure how to perform logging inside the nom parsing code without the messages being printed twice.