libc icon indicating copy to clipboard operation
libc copied to clipboard

Add missing musl utmpx.h constants

Open andrewliebenow opened this issue 1 year ago • 2 comments

andrewliebenow avatar Sep 09 '24 14:09 andrewliebenow

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Sep 09 '24 14:09 rustbot

See https://git.musl-libc.org/cgit/musl/tree/include/utmpx.h?h=v1.1.24.

I'm not sure if adding these constants would be considered a breaking change (https://doc.rust-lang.org/cargo/reference/semver.html#item-new).

andrewliebenow avatar Sep 09 '24 14:09 andrewliebenow