anderwm

On Foxy throws exception using diagnostic_aggregator tutorial

2

Not sure if the tutorial(https://wiki.ros.org/diagnostics/Tutorials/Configuring%20Diagnostic%20Aggregators) just needs updating or if the code could do some smart casting, but... Specifically the 'contains' field must be a list of strings now now...

Support for externally geared motor

5

I don't see any way to accomplish this with parameters alone. Is is reasonable to add an "external gear ratio" parameter (in controllers) and multiply the xxx_per_encoder_ticks parameters accordingly?

Maybe this is intended, but if so, it is an unfortunate name. GetCenter() seems to return the coordinates of what is at 0,0 in the footprint editor. As far as...