Alex Roan

@chainlink/contracts new major version branch

10

This is a long-lived branch containing a number of breaking changes to the @chainlink/contracts package. Currently implemented (applied to v0.8 contracts and above): * Alter interface contract naming scheme from...

Introduce array of roleIds

3

https://github.com/HQ20/contracts/blob/4c4acb1328d35659f18f10f0bcdcd54a74071c31/contracts/access/Hierarchy.sol#L19 using an array instead of a single role would allow multiple roles to be granted access to a function.

_grantRole in AccessControl.sol is private

1

https://github.com/HQ20/contracts/blob/4c4acb1328d35659f18f10f0bcdcd54a74071c31/contracts/access/Hierarchy.sol#L15 _grantRole() in AccessControl.sol is current private, so cannot be called by child contracts. [See here](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/access/AccessControl.sol#L183)

Updating the Open Oracle repo to represent the latest on-chain contracts - [Forum Discussion](https://www.comp.xyz/t/oracle-infrastructure-chainlink-proposal/1272) - [Successful Governance Proposal](https://compound.finance/governance/proposals/47) - [Execution Transaction](https://etherscan.io/tx/0x0b887d7398ab86f1dacb7e3cc18f400f29df800c8439c61878da26e71fd860ef) - [UniswapAnchoredView contract](https://etherscan.io/address/0x841616a5CBA946CF415Efe8a326A621A794D0f97)

Solidity: Incorrect code count from misreading valid comments

1

Running tokei on the solidity files in [this repo](https://github.com/Cyfrin/6-thunder-loan-audit/tree/main) returns incorrect code counts. The following example is from analyzing [`src/protocol/ThunderLoan.sol`](https://github.com/Cyfrin/6-thunder-loan-audit/blob/main/src/protocol/ThunderLoan.sol). This code snippet appears at the top of the file....

Safe.global WalletConnect app failing

1

## Bug description Attempting to connect the Beanstalk app to Safe via Walletconnect is failing. Browser console: ``` index.ts:82 WebSocket connection to 'wss://w.bridge.walletconnect.org/?env=browser&host=apps-portal.safe.global&protocol=wc&version=1' failed: value @ index.ts:82 ``` Also reported...

Openzeppelin's `Address` contract, or `AddressPlus` from [here](https://github.com/alexroan/solidity-library/blob/master/src/AddressPlus.sol).