chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard
verified publisher icon smartcontractkit

@chainlink/contracts new major version branch

Open alexroan opened this issue 3 years ago • 10 comments

This is a long-lived branch containing a number of breaking changes to the @chainlink/contracts package. Currently implemented (applied to v0.8 contracts and above):

  • Alter interface contract naming scheme from ExampleInterface.sol to IExample.sol

alexroan avatar Jun 27 '22 10:06 alexroan

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Jun 27 '22 10:06 github-actions[bot]

EVM Smoke Test Results

19 tests     8 :heavy_check_mark:  2m 39s :stopwatch:   1 suites  11 :zzz:   1 files      0 :x:

Results for commit 4a5447fe.

github-actions[bot] avatar Jun 27 '22 11:06 github-actions[bot]

EVM Smoke Test Results

19 tests     8 :heavy_check_mark:  2m 31s :stopwatch:   1 suites  11 :zzz:   1 files      0 :x:

Results for commit 9d5bd2f9.

github-actions[bot] avatar Jun 27 '22 13:06 github-actions[bot]

EVM Smoke Test Results

19 tests     0 :heavy_check_mark:  1m 9s :stopwatch:   1 suites  11 :zzz:   1 files      8 :x:

For more details on these failures, see this check.

Results for commit 3d4b87f1.

github-actions[bot] avatar Jun 28 '22 13:06 github-actions[bot]

EVM Smoke Test Results

19 tests     0 :heavy_check_mark:  1m 6s :stopwatch:   1 suites  11 :zzz:   1 files      8 :x:

For more details on these failures, see this check.

Results for commit 8a346a72.

github-actions[bot] avatar Jun 28 '22 15:06 github-actions[bot]

EVM Smoke Test Results

19 tests     0 :heavy_check_mark:  1m 5s :stopwatch:   1 suites  11 :zzz:   1 files      8 :x:

For more details on these failures, see this check.

Results for commit 8a346a72.

github-actions[bot] avatar Jun 28 '22 15:06 github-actions[bot]

EVM Smoke Test Results

19 tests     0 :heavy_check_mark:  1m 6s :stopwatch:   1 suites  11 :zzz:   1 files      8 :x:

For more details on these failures, see this check.

Results for commit 6f958bbd.

github-actions[bot] avatar Jun 29 '22 16:06 github-actions[bot]

EVM Smoke Test Results

19 tests     8 :heavy_check_mark:  2m 22s :stopwatch:   1 suites  11 :zzz:   1 files      0 :x:

Results for commit 3a7cceb5.

github-actions[bot] avatar Jun 30 '22 09:06 github-actions[bot]

EVM Smoke Test Results

26 tests   20 :heavy_check_mark:  4m 0s :stopwatch:   1 suites    6 :zzz:   1 files      0 :x:

Results for commit 7939bb69.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 30 '22 14:06 github-actions[bot]

@se3000 I've opted for option 1 and converted this into a long-lived branch.

As for the cutoff point, I think this sounds like a good place to stop here:

  • Interface renaming
  • Client renaming
  • Product based, client/internal directory structure

alexroan avatar Jul 11 '22 17:07 alexroan

Closing this based on conversations with @se3000 and @HenryNguyen5

alexroan avatar Aug 22 '22 15:08 alexroan