Tony Alberti

Results 134 comments of Tony Alberti

Since this is an API change, it'll need to be run through the gamut of downstream tests.

Converting to draft. This is looking like a fairly intrusive PR.

The coverage report doesn't seem right again. I'm seeing the same coverage report results over several PRs. Something is fishy with coveralls. Any ideas?

I wasn't assuming you were. There's a whole bunch of downstream PRs for this so yeah, it'll be a little while before we can make movement on this. Feel free...

> This PR is getting a bit old; there are a bunch of conflicts. > > Also, we should move the release note from `0.2.9` to `0.3.1`. @john-science ok, the...

@keckler I see this. It's a good idea. Once the unit tests pass, I will review.

> 1. There are some merge conflicts in this branch. Just need to merge in `main` and resolve them. > 2. Why is this PR on "Draft"? That's not a...

@keckler I've got a fairly big axial expansion refactor PR in the works that will incorporate these changes. So we can either 1) have you add the test to bump...

@keckler I'll just pull it in. Once the refactor PR comes in I'll tag you. That should hopefully come through soon.