Tony Alberti

Results 29 issues of Tony Alberti

I'm curious if there should be a setting to say which assemblies to skip and we can just configure our application to neglect control rods. _Originally posted by @jakehader (and...

enhancement
feature request

Let's format this better. The output is pretty ugly. You could use tabulate. _Originally posted by @jakehader in https://github.com/terrapower/armi/pull/823#discussion_r943819693_

feature request
low priority

Creating a block parameter for the axial expansion target component (stored as a string) would enable: 1. axial expansion target components to be determined through DB loading 2. allows users...

enhancement

In creating #797, a potential inconsistency in the expected use and reliability of axial mesh unification when `detailedAxialExpansion: False` was identified. In this scenario, the `o.r.core.refAssem` is typically used as...

architecture
complex

> I'm a little wary of keeping a BIG dictionary around with every Component in the Reactor in it. Maybe it's necessary, but this is essentially a shadow Reactor object...

cleanup

`core.findAllAxialMeshPoints()` includes 0.0 in its return. https://github.com/terrapower/armi/blob/1990fcd5c77d11797f41d29212b3d17a82ad1ed4/armi/reactor/reactors.py#L1810-L1813 `assembly.getAxialMesh()` does not https://github.com/terrapower/armi/blob/1990fcd5c77d11797f41d29212b3d17a82ad1ed4/armi/reactor/assemblies.py#L372-L375 This can be confusing in some instances and is an opportunity to improve consistency amongst related methods. An example...

enhancement

## The problem/observation - in marching through `armi/reactor/tests/test_reactors.py::loadTestReactor`, there are two designs stored in `bp.systemDesigns`, `Core` and `sfp`. https://github.com/terrapower/armi/blob/55766354067d8b1cffed02a48d36cd5d59c10718/armi/reactor/reactors.py#L145-L147 - The `core` object is built just before this for loop...

architecture
complex

## What is the change? Closes #769. A request was made to improve the axial linking logic to take advantage of the block grids system in ARMI. This PR aims...

enhancement

While doing a review for #1619, I found that the argument `rotationDegreesCCW` is unused -- and I don't see any downstream projects that use it. So I think it's ripe...

help wanted
good first issue
cleanup
low priority

## What is the change? This follows up on #909 and fully removes the `block.r` property. Leaving it causes some (imo) unnecessary tangling. So instead of the current ```text Reactor...

architecture