Results 44 comments of Adam Saghy

@alberto-art3ch I dont see any testing! Please consider writing unit tests to cover this new behaviour! The test should check whether properly handled the CANCELLATION if there is no ACTIVE...

@mariiaKraievska Please kindly check @vidakovic recommendation and resolve the conflicting files and squash the commits! Thank you! ;)

@mariiaKraievska Kindly asking you to squash your commits and resolve the conflicts. Feel free to reach out if you are facing any issues with that.

> > @adamsaghy I'm sorry for the delay. (I thought I could quickly deal with the problem and then write back, but no). I'm a bit stuck with these two...

> @adamsaghy Related to the problem of having in the same transaction queries that use `jdbcTemplate` and new, rewritten queries that use `QueryDSL'. I propose to go the way of...

@jogathogo Please squash your commits and check why the tests were failing!

Please kindly see the discussion under the JIRA story: https://issues.apache.org/jira/browse/FINERACT-2062 Also please make sure you are following the proper commit message requirements: "FINERACT-: " Example: FINERACT-2062: Use 48 weeks in...

@HarimbolaSantatra Please follow the conventions on how to format the pull request title ("[FINERACT-1234](https://issues.apache.org/jira/browse/FINERACT-1234): Title of the JIRA ticket") Same applies for the commit message as well