fineract icon indicating copy to clipboard operation
fineract copied to clipboard

FINERACT-2062: Use 48 weeks in a year when interest rate is per month

Open wkigenyi opened this issue 1 year ago • 4 comments

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [ ] Create/update unit or integration tests for verifying the changes made.

  • [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

wkigenyi avatar Mar 12 '24 13:03 wkigenyi

Please kindly see the discussion under the JIRA story: https://issues.apache.org/jira/browse/FINERACT-2062

Also please make sure you are following the proper commit message requirements: "FINERACT-<JIRA_STORY_NUMBER>: " Example:
FINERACT-2062: Use 48 weeks in a year if interest rate is monthly

adamsaghy avatar Mar 18 '24 13:03 adamsaghy

Thanks for the guidance @adamsaghy. I am following the conversation jira.

wkigenyi avatar Mar 19 '24 05:03 wkigenyi

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar May 04 '24 00:05 github-actions[bot]

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Sep 06 '24 00:09 github-actions[bot]