Adam Dossa
Adam Dossa
This was mentioned as being an item which was needed for v1 (i.e. the 31st Jan mainnet deployment). I think the most straightforward approach is to change `KYC` in Template.sol...
This sounds sensible to me - do you want to do this in a standalone PR and we can then all review?
Any reason for this? I'd have thought it would be fine for an admin to remove themselves as admin. Note that a non-admin can't add themselves as an admin as...
I'm not sure that `voteToUnfreeze` would work well. What is the intention for frozen funds? My assumption is that allocations which are frozen after a vote should be refunded to...
OK - so for now let's leave this as it is which is as an option of last resort (since investors have no economic incentive to freeze, they would need...
I will add some more detail for this: `NameSpaceRegistrar` - this is a simple standalone contract which allows `admins` to "pre-register" token symbols, under a given namespace, on behalf of...
Bit confused by the function `function addToWhitelist(address _KYC)` - this now adds msg.sender to the whitelist, rather than an address supplied as a parameter. Is this intentional? If so, please...
Approved, but marked as WIP whilst we wait for final product approval and decide if this constitutes a breaking change.
Is it expected that this PR will be merged in the near future? We have a downstream dependency for our Polymesh Wallet which requires this in order to move to...
@claude Can you review this PR focussing on safety. Provide a short summary as a comment highlighting any concerns related to these changes.