polymath-core-deprecated icon indicating copy to clipboard operation
polymath-core-deprecated copied to clipboard

Ticker Reg: have securityTokenRegistrar check namespaceRegistrar before allowing a ticker name to be registered

Open pabloruiz55 opened this issue 7 years ago • 2 comments

The STregistrar should check the namespaceRegistrar to make sure that the ticker name that is being registered has not been reserved. It should also make sure the reservation has not yet expired. (90 days from reserve date.)

pabloruiz55 avatar Feb 25 '18 23:02 pabloruiz55

In the function registerToken() of the NameSpaceRegistrar.sol you are having this line. require(symbolOwner[_nameSpace][_symbol] == address(0));

This line will fail ticker registration if one has been already registered for the name space. Do you require additional constant function which will return e.g. false or true to indicate status of the ticker registration?

win2win avatar Feb 26 '18 16:02 win2win

I will add some more detail for this:

NameSpaceRegistrar - this is a simple standalone contract which allows admins to "pre-register" token symbols, under a given namespace, on behalf of Issuers.

SecurityTokenRegistrar - this is the entry point for Issuers to the Polymath protocol. New security tokens are created by calling createSecurityToken, passing in an _owner who will be the owner of the newly created security token (ST).

This task is to have the SecurityTokenRegistrar contract check whether anyone has reserved the token symbol being passed in createSecurityToken. If it has been reserved, then the _owner must match the address which reserved the token in NameSpaceRegistrar. If it hasn't been reserved, then it is fine, nothing needs to happen in NameSpaceRegistrar.

In addition, if the token was reserved more than 90 days ago, but has not yet been created through createSecurityToken then the reservation should not count.

adamdossa avatar Feb 26 '18 16:02 adamdossa