polymath-core-deprecated icon indicating copy to clipboard operation
polymath-core-deprecated copied to clipboard

Ticker Reg: prevent an admin from removing himself as admin

Open pabloruiz55 opened this issue 7 years ago • 2 comments

Require that msg.sender != the address to remove/add as admin

pabloruiz55 avatar Feb 25 '18 23:02 pabloruiz55

Any reason for this? I'd have thought it would be fine for an admin to remove themselves as admin. Note that a non-admin can't add themselves as an admin as they wouldn't be able to call the function in the first place.

adamdossa avatar Feb 26 '18 12:02 adamdossa

The problem with that is that if an admin can remove his own address, then there's the chance of locking everyone out of the contract and having no admin.

pabloruiz55 avatar Feb 26 '18 12:02 pabloruiz55