Alexander Aprelev
Alexander Aprelev
Perhaps worth clarifying that landed PR implemented optimization in AOT only, creating a separate issue for extending it to JIT as well.
now on dartk-linux-release-ia32 https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8832699001736295281/+/u/test_results/stdout
Turned again [log](https://dart-ci.appspot.com/log/vm-kernel-optcounter-threshold-linux-release-x64/dartk-optcounter-linux-release-x64/14281/service_2/async_generator_breakpoint_test/dds_1)
happened again https://dart-ci.appspot.com/log/vm-kernel-checked-linux-release-x64/dartk-checked-linux-release-x64/13444/service_2/async_generator_breakpoint_test/dds_1
looks like a typo in line 8 ` return clone; List.of(array, growable: false);`
Based on conversation with @alexmarkov: one possible path forward with this would be to introduce another pragma (`vm:prefer-inline-if-concrete-arg-types-known`?) along the lines of `vm:prefer-inline`/`vm:never-inline` so it can drive more aggressive inlining...
cc @rmacnak-google
> Where is the Dart version of clang coming from? https://dart-review.googlesource.com/c/sdk/+/248720 attempted to align dart clang with flutter/fuchsia one. > Why is Dart seeing this issue with a new clang...
> That is, leave zlib where it is Strategically it seems to be a bad place to be in, especially considering recent need to roll zlib. Do you have a...
Okay, for now we landed https://dart-review.googlesource.com/c/sdk/+/249542 that keeps zlib as it was.