Alexander Aprelev

Results 91 comments of Alexander Aprelev

> an isolate could manipulate files owned by another isolate by forging the integer file descriptor I think the intent would be keep file descriptors(perhaps `FileDescriptionReference`) opaque objects, rather than...

I thought android simulator used for internal testing only supports x86

Failed again https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8811908224943216881/+/u/test_results/new_test_failures__logs_ ``` SocketException: Write failed (OS Error: Broken pipe, errno = 32), port = 0 #0 _NativeSocket.write (dart:io-patch/socket_patch.dart:1190:34) #1 _RawSocket.write (dart:io-patch/socket_patch.dart:1912:15) #2 _Socket._write (dart:io-patch/socket_patch.dart:2352:18) #3 _SocketStreamConsumer.write (dart:io-patch/socket_patch.dart:2100:26) #4...

Happened again https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/front-end-mac-release-x64/19959/overview https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/front-end-mac-release-x64/19955/overview

Few more https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/front-end-mac-release-x64/19965/overview https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/front-end-mac-release-x64/19963/overview

Failed again https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8802943795756537457/+/u/test_results/new_test_failures__logs_

For reference and to check performance impact I put together https://dart-review.googlesource.com/c/sdk/+/258600 which adds 32-bit [MurmurHash](https://en.wikipedia.org/wiki/MurmurHash) implementation on ia86/x64 platforms. Running benchmarks shows huge improvements on [newly added IntegerSetLookup ](https://dart-review.googlesource.com/c/sdk/+/259240)benchmark built...

> Do we need `int.hashCode` to be the same on different architectures? I think we do due to vm snapshots (with constants, hash values, but without actual code) potentially shared...

Tried various constants and hashing sequences, the[ following ](https://dart-review.googlesource.com/c/sdk/+/258600) seems to produce best results on x64 on existing benchmarks(inlined via graph intrinsics) ``` __ movq(RDX, compiler::Immediate(0x2d51)); __ imulq(RDX); __ xorq(RAX,...

[front-end-nnbd-linux-release-x64](https://ci.chromium.org/p/dart/builders/ci.sandbox/front-end-nnbd-linux-release-x64)