Zeeshan Ahmed

Results 11 comments of Zeeshan Ahmed

I think the PR is ready for review, I need to do refactoring, but I'll need feedback for that. @tanujkhattar

Serial concatenation is done by using the `superoperator` intermediate. The same can't be done for mixtures so that has remained unchanged. Since the qubits can not be passed to `superoperator`...

mixture protocol has been restructured with serial concatenation as a part of it, serial concatenation uses superoperator as intermediate after decomposing the given operator. If any of the decomposed operators...

With the newly proposed structure of `kraus` and `has_kraus`, some issues are required to be handled. - Re-structuring of `has_kraus` results in the protocol taking alternative methods rather than returning...

To complete the restructuring, #4876 must be merged.

A simple test for `cpfp` has been written, I'm not sure what other kinds of tests are required. Please let me know

I am unable to figure out a simple way of testing CPFPing multiple SpendTransactions, if there is a simpler scheme that I can follow please let me know. The Current...

I’m already working on this, some overview: - Serial concatenation will use `superoperator` as intermediate. Since there is no direct way of interconversion, `kraus` will also be another intermediate between...

There is another issue that I am facing, I am not sure when to construct the `CPFP` variant of `SpendTransaction` under which I have implemented it since I assumed that...

After further studying, I think it is best to not treat `CPFP` as a `SpendTransactionAction` but treat it separately and common for all the transactions. But the view will be...