Cirq icon indicating copy to clipboard operation
Cirq copied to clipboard

Kraus operator resolved with serial concatenation

Open Zshan0 opened this issue 4 years ago • 3 comments

As requested in #3965

Made modifications to kraus in kraus_protocol.py by adding serial concatenation as mentioned.

Also added a test based on the issue.

Have Not implemented the precautions to avoid "large amount of combinatorial explosion" as I'm unclear on what "large amount" should be.

Zshan0 avatar Sep 05 '21 08:09 Zshan0

cc #4434

@Zshan0 Can you please fix the failing tests?

tanujkhattar avatar Sep 05 '21 22:09 tanujkhattar

I think the PR is ready for review, I need to do refactoring, but I'll need feedback for that. @tanujkhattar

Zshan0 avatar Sep 28 '21 08:09 Zshan0

Serial concatenation is done by using the superoperator intermediate. The same can't be done for mixtures so that has remained unchanged. Since the qubits can not be passed to superoperator while construction, that still has to be done manually using tensor products. Changed serial concatenation test, the new comparison is done after converting to superoperator as advised.

Zshan0 avatar Oct 25 '21 14:10 Zshan0