Paul Doyle
Paul Doyle
Digging around a bit, it looks like this is partially related to the logic in `assign`: https://github.com/Roblox/roact/blob/f55538b529f59683eec1ee75bd8735bb6fdefc98/src/assign.lua#L13-L21 If all of the inputs that we're copying _from_ are empty or nil,...
The best practice as of Roact 1.x is to call setState instead of assigning directly. https://roblox.github.io/roact/api-reference/#init (as well as the examples in the "Guide" section of the docs) should be...
If I understand correctly, the only time that this will be an improvement is if we're using the store and thunks to to trigger a side effect without actually changing...
This still looks good to me, but I did some digging into why React doesn't do this, and here's what I found: https://github.com/reactjs/rfcs/pull/4#issuecomment-412637588 It's a pretty important point to make!...
One more thing to note as a followup: we do also have the same problem already with closing over initial props passed into `init`, so we should keep that in...
Okay, that makes sense. I had a feeling it might be infeasible. Thanks for the explanation!
Hi, this looks like a great example! If you're interested, you could make a PR to the docs (we use `mkdocs`, which should be pretty easy to set up locally)...
Funny, I just bumped into this myself. When I added this, I didn't think too much about it, but you're absolutely right about it being misleading. I think the best...
Thank you for the contribution; please accept the SLA and I'd be glad to merge it
Thank you, looks good. If you accept the SLA, I can merge this.