rodux icon indicating copy to clipboard operation
rodux copied to clipboard

Fixed typo in example.md

Open HenryAtBraveTurtles opened this issue 2 years ago • 5 comments

HenryAtBraveTurtles avatar Jun 10 '23 15:06 HenryAtBraveTurtles

Makes sense to just use a placeholder. No reason for an actual phone number in example documentation.

Thanks for the approval. This isn't just about not using the actual number, I guess I wasn't very clear on the typo part.

I've requested this to match the value with the "Expected Output" in your documentation, hope this helps.

--[[
	Expected output to the developer console:

	Action dispatched: {
	    phoneNumber = "12345678" (string)
	    type = "ReceivedNewPhoneNumber" (string)
	}
	State changed to: {
	    myPhoneNumber = "12345678" (string)
	    myFriends = {
	    }
	}
	Action dispatched: {
	    newFriends = {
	        1 = "Cassandra" (string)
	        2 = "Joe" (string)
	    }
	    type = "MadeNewFriends" (string)
	}
	State changed to: {
	    myPhoneNumber = "12345678" (string)
	    myFriends = {
	        1 = "Cassandra" (string)
	        2 = "Joe" (string)
	    }
	}
]]

HenryAtBraveTurtles avatar Sep 24 '23 20:09 HenryAtBraveTurtles

Thanks for the approval. This isn't just about not using the actual number, I guess I wasn't very clear on the typo part.

I've requested this to match the value with the "Expected Output" in your documentation, hope this helps.

Certainly does help. Thanks for the clarification. Either way it made sense, but with the additional information provided by yourself it further enhances why this PR should be accepted. Good spot & nice work 😊👍

Awokein avatar Sep 24 '23 20:09 Awokein

Thank you for the contribution; please accept the SLA and I'd be glad to merge it

ZoteTheMighty avatar Jan 10 '24 00:01 ZoteTheMighty

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jan 10 '24 00:01 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

HenryAtBraveTurtles avatar Jan 11 '24 03:01 HenryAtBraveTurtles