Daniel Skates
Daniel Skates
My two cents: when a PR is still drafting, I tend to rebase it a bit, I think maybe limit this to things that are `S-Needs-Review` or later (or similar)
I suggest reviewing commit by commit - commits are now in the following order: - Boilerplate for `bevy_material` and `bevy_material_macros` - Conversions required later on (e.g. `From` changes, etc.) -...
This also allows for `bevy_gltf` to no longer depend on `bevy_pbr` , see this follow-on commit https://github.com/Zeophlite/bevy/commit/e712d5363d6f04560f923f548d71ac4eee78a432
See https://github.com/Zeophlite/bevy/pull/5 as a follow-up PR , that shows that `bevy_gltf` can not depending on `bevy_pbr` or `bevy_render`
> You added a new feature but didn't update the readme. Please run `cargo run -p build-templated-pages -- update features` to update it, and commit the file change. Unrelated to...
Alternative followup - https://github.com/Zeophlite/bevy/pull/6