bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Move `MaterialProperties` from `bevy_pbr` to `bevy_material`

Open Zeophlite opened this issue 3 months ago • 7 comments

Objective

  • Move MaterialProperties from bevy_pbr to bevy_material (new crate that doesn't depend on wgpu , just wgpu-types )
  • This also allows for bevy_gltf to no longer depend on bevy_pbr , see this follow-on commit https://github.com/Zeophlite/bevy/commit/e712d5363d6f04560f923f548d71ac4eee78a432

Solution

  • Move stuff, mainly look at these 3 crates:
    • from bevy_pbr to bevy_material
    • from bevy_render to bevy_material
    • from bevy_pbr to bevy_render

Testing

  • Builds

Zeophlite avatar Oct 14 '25 19:10 Zeophlite

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

github-actions[bot] avatar Oct 14 '25 19:10 github-actions[bot]

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

github-actions[bot] avatar Oct 15 '25 23:10 github-actions[bot]

I suggest reviewing commit by commit - commits are now in the following order:

  • Boilerplate for bevy_material and bevy_material_macros
  • Conversions required later on (e.g. From<World> changes, etc.)
  • Moves (generally one file at a time)

Have a look at the migration guide for a summary of all moves

Zeophlite avatar Oct 17 '25 07:10 Zeophlite

This also allows for bevy_gltf to no longer depend on bevy_pbr , see this follow-on commit https://github.com/Zeophlite/bevy/commit/e712d5363d6f04560f923f548d71ac4eee78a432

Zeophlite avatar Nov 30 '25 16:11 Zeophlite

See https://github.com/Zeophlite/bevy/pull/5 as a follow-up PR , that shows that bevy_gltf can not depending on bevy_pbr or bevy_render

Zeophlite avatar Dec 02 '25 12:12 Zeophlite

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

github-actions[bot] avatar Dec 02 '25 13:12 github-actions[bot]

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

Unrelated to this PR, see https://github.com/bevyengine/bevy/pull/22008

Zeophlite avatar Dec 02 '25 15:12 Zeophlite

Alternative followup - https://github.com/Zeophlite/bevy/pull/6

Zeophlite avatar Dec 06 '25 04:12 Zeophlite