Move `MaterialProperties` from `bevy_pbr` to `bevy_material`
Objective
- Move
MaterialPropertiesfrombevy_pbrtobevy_material(new crate that doesn't depend onwgpu, justwgpu-types) - This also allows for
bevy_gltfto no longer depend onbevy_pbr, see this follow-on commit https://github.com/Zeophlite/bevy/commit/e712d5363d6f04560f923f548d71ac4eee78a432
Solution
- Move stuff, mainly look at these 3 crates:
- from
bevy_pbrtobevy_material - from
bevy_rendertobevy_material - from
bevy_pbrtobevy_render
- from
Testing
- Builds
You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.
Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.
I suggest reviewing commit by commit - commits are now in the following order:
- Boilerplate for
bevy_materialandbevy_material_macros - Conversions required later on (e.g.
From<World>changes, etc.) - Moves (generally one file at a time)
Have a look at the migration guide for a summary of all moves
This also allows for bevy_gltf to no longer depend on bevy_pbr , see this follow-on commit https://github.com/Zeophlite/bevy/commit/e712d5363d6f04560f923f548d71ac4eee78a432
See https://github.com/Zeophlite/bevy/pull/5 as a follow-up PR , that shows that bevy_gltf can not depending on bevy_pbr or bevy_render
You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.
You added a new feature but didn't update the readme. Please run
cargo run -p build-templated-pages -- update featuresto update it, and commit the file change.
Unrelated to this PR, see https://github.com/bevyengine/bevy/pull/22008
Alternative followup - https://github.com/Zeophlite/bevy/pull/6