YenForYang
YenForYang
"No token found in response" when googleAccount (`googleLoginHint`) is specified. https://github.com/honestbleeps/Reddit-Enhancement-Suite/blob/5e2630b00a5837f9a59b8fbbefd8aa4acf136953/lib/environment/foreground/auth.js#L28-L41 I looked into the value of `responseUrl` when `googleLoginHint` is specified, and it's of the form: ``` https://accounts.google.com/o/oauth2/v2/auth?login_hint=&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive.appdata&response_type=token&redirect_uri=https%3A%2F%2Fredditenhancementsuite.com%2Foauth&client_id=568759524377-nv0o2u4afuuulkfcjd7f6guf27qkevpt.apps.googleusercontent.com&hd=&as=... ```...
https://github.com/anacrolix/torrent/blob/175b826e738c76d1a96e435bc5396e054ca5796a/tracker_scraper.go#L202-L208 I'm confused on why locking the client is necessary for assigning `lastAnnounce`. It doesn't look like `lastAnnounce` is read anywhere besides in `trackerScraper.statusLine()` and only written in `Run()`.
I've found some cases where `pp.Integer` is used to denote the index of pieces. This is not an issue at all, but it turns out `PieceIndex` is `int` (effectively `int64`)...
I think this would be better long term, considering that each `File` instance is owned by a `Torrent`. Ultimately the more pointers we have the more the GC has to...
https://go.godbolt.org/z/rnMec6Tnx --- Yup, Go's compiler is really dumb.
See https://github.com/go101/go101/wiki/There-is-not-a-perfect-way-to-clone-slices-in-Go.
Changing this will probably help to eliminate the confusing type aliases and cleanup imports a bit. I don't think `AnnounceEvent` is best suited to be in tracker/udp. I used golang.org/x/tools/cmd/stringer...
Sucks that reflection has so much overhead. Hygienic macros would definitely have helped here. Note I didn't use keys for the struct initialization -- this is to ensure that you...
Temporary stand-in until we get something better (hopefully when generics come around). Also fixed `(trackerScraper).URL()` to use a pointer receiver instead; don't know if original copying was intended (as it...