YenForYang
YenForYang
Interesting, Just noticed this on caps2esc as well. Wonder why...
Ok gotcha. I think delving into atomics could benefit this library as a whole. Do you mind a change to atomic.Value here? My main concern is that it seems like...
Hmm then I'll change it to not use `String` if the current implementation works as expected. Namely the `To4()` and `To16()` calls can be squashed into something less confusing, but...
@anacrolix `addrIpOrNil` was used in the original implementation and also calls `String()` if `net.Addr` is not `UDPAddr` or `TCPAddr`. I think I'll fallback to a string check just like `addrIpOrNil`.
I'm thinking about writing a small wrapper type to encapsulate `chan struct{}`, which will probably make this more readable. Something small like `type ChanEmptyStruct chan struct{}`. Probably will make an...
Alright should be good now. Didn't think too hard about naming the methods for the wrapper -- I've seen stuff like `Broadcast()`, `Signal()`, `Set()`, etc. but since all that's up...
Yep it definitely would, but currently `Client.torrents` uses a `map[InfoHash]*Torrent`, so the issue would be moving away from using `InfoHash` to a slice index. Slightly more involved but probably worth...
Any issues with this PR?
I should mention that this pull request incorporates https://github.com/anacrolix/torrent/pull/594, so that one can be closed when this one is accepted.
Looks like https://github.com/anacrolix/torrent/pull/594 was merged, so I made some updates.