Abhishek Singh
Abhishek Singh
It's not a mistake, 'key' parameter is used in reconciliation to optimize render performance . And it's right way of writing code when using ```.map```
I agree but I don't have access to perform reverts, also @ovflowd might have put some thought before allowing to raise PR.
I really don't understand how it got closed, i shall be adding new PR again.
@bmuenzenmeyer i recreated this PR as #6924 and would like to request review on it.
Hi, I want to contrubute in this issue. Should i update it with new link as given by @andresakata, or remove it.
Ok , will add css for small screens only
My finding is issue only persists where `ArticleLayout` comp is used. For check - I inserted dummy data in /about , and was working fine , no sticky footer https://github.com/nodejs/nodejs.org/assets/99867024/f64f3e36-0428-4be2-8412-1be64446afba
applied external css on \ , on small screen, it will appear above breadcrumb. otherwise working noramlly. UI looks good too. https://github.com/nodejs/nodejs.org/assets/99867024/b0d3808b-16ed-422b-864a-9b9a1d0e2d9b
@bmuenzenmeyer @abizek @canerakdas Can you please review my latest commit to consider it for merge. Let me know if it needs any changes. Thanks.
@ovflowd which layout will be good? (below) 1. height- 100vh ( has better responsivity in medium devices too) https://github.com/nodejs/nodejs.org/assets/99867024/9cae63a1-9d3e-4538-b1fe-d308371e8bbe 2. height -100% https://github.com/nodejs/nodejs.org/assets/99867024/a30a6fa3-1e29-413b-9a4d-0fe58b35c764 I hope it address sticky issue.