nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: Removed misleading info

Open Wellitsabhi opened this issue 1 year ago • 6 comments

Description

Removed the misleading info as mentioned in issue #6853

Validation

image

Related Issues

Fixes: #6853

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npm run format to ensure the code follows the style guide.
  • [x] I have run npm run test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

Wellitsabhi avatar Jun 21 '24 13:06 Wellitsabhi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 7, 2024 4:29am

vercel[bot] avatar Jun 21 '24 13:06 vercel[bot]

@Wellitsabhi I think reverting the changes directly from the merged PR page will be a better choice for clarity and consistency rather than merging a new PR with a manual revert might create unnecessary changes.

TenzDelek avatar Jun 21 '24 15:06 TenzDelek

I agree but I don't have access to perform reverts, also @ovflowd might have put some thought before allowing to raise PR.

Wellitsabhi avatar Jun 22 '24 08:06 Wellitsabhi

I don't follow why this approach would be bad. Don't worry about it. Clean git history is overrated.

That said, we're not meeting anything until monorepo conversion stabilizes.

bmuenzenmeyer avatar Jun 22 '24 14:06 bmuenzenmeyer

I don't follow why this approach would be bad. Don't worry about it. Clean git history is overrated.

That said, we're not meeting anything until monorepo conversion stabilizes.

Can't agree more on this, :)

TenzDelek avatar Jun 22 '24 16:06 TenzDelek

This PR will need to be rebased or recreated now that https://github.com/nodejs/nodejs.org/pull/6850 merged.

bmuenzenmeyer avatar Jul 05 '24 11:07 bmuenzenmeyer

I really don't understand how it got closed, i shall be adding new PR again.

Wellitsabhi avatar Jul 07 '24 05:07 Wellitsabhi

@bmuenzenmeyer i recreated this PR as #6924 and would like to request review on it.

Wellitsabhi avatar Jul 12 '24 14:07 Wellitsabhi