Trenton Bricken comments

Results 21 comments of


                                            Trenton Bricken

Document better that loading a dataset passing its name does not use the local script

That makes sense but I think having a line about it under https://huggingface.co/docs/datasets/installation#source the "source" header here would be useful. My mental model of `pip install -e .` does not...

Loss function drmsd component commented out

Lines 53 and 56 of `openprotein.py`

Loss function drmsd component commented out

While on the topic of loss functions, am I right that you apply the mask to the tertiary structure **and** primary sequence when you preprocess the data rather than masking...

soft_to_angle theory

Along similar lines in `preprocessing.py` you take the ProteinNet tertiary data which is in coordinate format, and then convert it into angles and then back to coordinates again. Why? Starting...

soft_to_angle theory

Any further insight on this would be really appreciated!

soft_to_angle theory

Thanks, I read this paper a while ago and didn't remember there being the right side of figure 2 with the "torsional alphabet", it may have been added in a...

Multiprocessing very slow

I have started using the Ray multiprocessing library which so far seems to be working very well.

Can you provide the training parameters?

In the install readme add in a requirement for Tensorflow-probability?

When I was first getting errors I did try the Numpy version but recall errors also appearing then. I think the easiest fix for now to help future "TrentBricks" would...

Example code for Discrete Flows?

No worries, if you could share the code used create the initial figures in the paper (discretized mixture of gaussians and Potts model) that would be really helpful. I have...