google
In the install readme add in a requirement for Tensorflow-probability?
In the install section of the readme please consider adding in something about having TensorFlow probability.
I have spent too much time trying to install Edward2 and its dependencies by hand. I tried using the command:
pip install edward2[tensorflow] @ "git+https://github.com/google/edward2.git#egg=edward2"
But on macOS Catalina with zsh as my command line I got an error with the @ sign where it said:
ERROR: Invalid requirement: '@'
It was only when I looked at setup.py directly that I saw tensorflow-probability was one of the requirements and required a separate command line install.
Up until this point I had Edward2 installed but none of the example code would work eg I got an error saying that ed.Normal did not exist.
Hmm that command should definitely just work. Open to finding a fix, perhaps something like wrapping the quotes around "edward2[tensorflow] @ git+https://github.com/google/edward2.git#egg=edward2"? Not sure.
On the high-level question, we're hoping to open up the use of Edward2 on the NumPy (and potentially JAX) ecosystems, hence the directory separation between TF-specific code, NumPy-specific code, and backend-agnostic code. Here's an example implementation we did in Autoconj, which used the Autograd backend. If you don't have requisites for one of these backends like TF installed, the non-TF API should not be raising errors until you try to use something from the TF API.
When I was first getting errors I did try the Numpy version but recall errors also appearing then. I think the easiest fix for now to help future "TrentBricks" would be to add some mention of TF Probability in the install section of the README. It is great you guys are adding JAX functionality!
Hmm that command should definitely just work. Open to finding a fix, perhaps something like wrapping the quotes around
"edward2[tensorflow] @ git+https://github.com/google/edward2.git#egg=edward2"? Not sure.
This worked for me! Thanks a lot
