Todd Grunke

[info request] traceparent and general logging question

11

I've got a question about logging in O#. For context, I work on the Visual Studio web tooling team, and we are using O# for html and css language server...

Lexer.LexDirectiveTrailingTrivia was calling into AddTrivia with a null SyntaxListBuilder, causing allocations. Instead, use the existing _trailingTriviaCache member in that context. From the non-devenv allocations Completion speedometer: 

Reduce allocations under RemoteAssetProvider.SynchronizeAssetsAsync

2

This code realized an ImmutableArray before from an ArrayBuilder. This immutablearray was only used within the scope of SynchronizeAssetsAsync. *** Prior allocations from speedometer: 

Reduce ImmutableDictionary allocations under SolutionCompilationState by using ImmutableSegmentedDictionary

5

The _projectIdToTrackerMap member is heavily indicted in the non-devenv allocations in the CompletionTest.Completions speedometer test (over 1 GB of allocations). As this member is private, we have the ability to...

Reduce symbol array allocations during CSharpSemanticModel.LookupSymbolsInternal

2

During completion, I see this method generating results with several thousand entries which is evident in allocations in a profile I'm inspecting. This PR attempts to reduce intermediary arrays constructed...

The _projectIdToTrackerMap member is heavily indicted in the non-devenv allocations in the CompletionTest.Completions speedometer test (over 1 GB of allocations). As this member is private, we have the ability to...

WIP: Reduce ImmutableDictionary allocations under SolutionCompilationState

2

The _projectIdToTrackerMap member is heavily indicted in the non-devenv allocations in the CompletionTest.Completions speedometer test (over 1 GB of allocations). As this member is private, we have the ability to...

Closure allocated in TokenizerBackedParser.PushSpanContextConfig

1

Found while investigating allocations in the completion speedometer test. @333fred -- @DustinCampbell mentioned this might be going away soon, if so, then I guess this bug can just be closed....

Modify refdump to allow regular expression usage for the file pattern.

3

WebTools uses refdump to find references to our public API surface area from VS marketplace extensions. However, some of these extensions include our assemblies, and thus a lot of extra...

Attempt to move several data structures to be immutable

1

# Bug Fixes: https://github.com/NuGet/Home/issues/13647 Reduces allocations during solution load in VS ## Description Modified several data structures to be immutable, such that the PackageSpec.Clone operation can allocate significantly less. The...