Todd Grunke
Todd Grunke
Any update on whether consuming StreamJsonRpc is a possibility moving forward?
I believe ICodeActionHandler and ICompletionHandler also have nullability issues
@333fred for 2nd review
@dotnet/roslyn-compiler for a 2nd review
Nudge to @dotnet/roslyn-compiler again for 2nd review
This looks effective from the [speedometer run](https://devdiv.visualstudio.com/DevDiv/_apps/hub/ms-vseng.pit-vsengPerf.pit-hub?targetBuild=34622.165.dn-bot.240223.030609.530878&targetBranch=34622.165.dn-bot.240223.030609.530878&targetPerfBuildId=9123365&runGroup=Speedometer&since=2024-02-23&baselineBuild=34622.165&baselineBranch=main) here (CompletionTest.Completion/9990.Totals/CLR_BytesAllocates_NonDevenv) ``` Name Exc % Exc Type Microsoft.CodeAnalysis.Checksum[] 0.1 4,900,776 ``` No HashSet\ appears in the profile. Going to elevate out of...
@sharwell, @CyrusNajmabadi -- I've moved this out of draft status as it shows promise, ptal
> Requesting changes pending investigation on not losing argument immutability Would like to ping @CyrusNajmabadi and @sharwell for preferences on how to proceed. I personally don't mind sending the mutable...
> Requesting changes pending investigation on not losing argument immutability @sharwell -- I'd like to keep this moving along. Do you think the ValueBuilder PR will go in sometime soon,...
waiting on #72395 as it provides the ImmutableCollectionsMarshal this PR wants