Benjamin Ansbach
Benjamin Ansbach
Yes, it seems to work with an include on the config file instead of the laravel `config()` function. See here: https://github.com/Edujugon/laravel-google-ads/blob/master/src/Support/helpers.php#L52-L67 There is a workaround, you might give this a...
I think its unnecessary
The tests don't execute HTTP requests, the tests work with some fixtures that take a lot of time to load - at least that is what I recognized the last...
There was a simple reason why it looks like that. The old iota.lib.js looked like this: https://github.com/iotaledger/iota.js/blob/4735f0c5a39d73f6fa43de51d4334278347e5ffb/dist/iota.js#L4181-L4192 And I wanted to make it simpler to compare both versions in case...
You can keep the one we have now and add the others if applicable.
Well, we use `filter_var($neighborUri, FILTER_VALIDATE_URL)` and this will also, for instance, allow http://www.iota.org:12345 - so it's not the same. The [isUri](https://github.com/iotaledger/iota.js/blob/next/packages/guards.ts#L131-L143) implementation is much more detailed and restrictive. Im not...
I don't see the immediate need but if you want to add this functionality, go for it. Won't hurt anyone to have this check :-)