Peter Mottram
Peter Mottram
excellent :+1:
@racke you promised to have a look at this...
Since current behaviour is clearly broken I'd like to propose that we mark `uri_base` as deprecated and remove it from all docs. The new method as proposed by @veryrusty is...
:-1: Passphrase: [Github](https://github.com/hvoers/Dancer2-Plugin-Passphrase) ``` t/003_default_settings.t .. Use of uninitialized value $Dancer2::Plugin::CUR_PLUGIN in string at /home/apm/git/Dancer2/lib/Dancer2/Plugin.pm line 247. Can't find originating plugin at t/003_default_settings.t line 5. ```
:-1: Deferred This plugin does: `use Dancer2::Plugin qw(:no_dsl);` which is what breaks things. If `:no_dsl` is removed then tests all pass. It also passes against 0.165 with this change.
:-1: Auth::Extensible: [Github](https://github.com/PerlDancer/Dancer2-Plugin-Auth-Extensible) Same issue as Passphrase: ``` t/01-basic.t ...... Use of uninitialized value $Dancer2::Plugin::CUR_PLUGIN in string at /home/apm/git/Dancer2/lib/Dancer2/Plugin.pm line 247. Can't find originating plugin at t/lib/TestApp.pm line 10. ```
:-1: Auth::OAuth: [Github](https://github.com/b10m/p5-Dancer2-Plugin-Auth-OAuth) PR submitted to remove 'use Dancer2' https://github.com/b10m/p5-Dancer2-Plugin-Auth-OAuth/pull/7 Once patch is applied breaks in the same way as Passphrase and Auth::Extensible.
:-1: DBIC: [Github](https://github.com/ironcamel/Dancer2-Plugin-DBIC) ``` t/04-testapp.t ........... Specific subroutines cannot be exported from plugin at t/lib/TestApp.pm line 5. ``` Due to this in the test: `use Dancer2::Plugin::DBIC qw(schema resultset);` Simple fix...
:-1: Feed: [Github](https://github.com/hobbestigrou/Dancer2-Plugin-Feed) Just need to remove `use Dancer2`. PR submitted.https://github.com/hobbestigrou/Dancer2-Plugin-Feed/pull/5
:-1: JWT: [Github](https://github.com/ambs/Dancer2-Plugin-JWT) Two problems here. One was solved by using `plugin_setting` DSL: ``` --- a/lib/Dancer2/Plugin/JWT.pm +++ b/lib/Dancer2/Plugin/JWT.pm @@ -15,7 +15,7 @@ my $config; sub _get_secret { my $dsl =...