Peter Mottram

Results 33 comments of Peter Mottram

:-1: Redis: [Github](https://github.com/burnersk/Dancer2-Plugin-Redis) `use strictures 1` along with `plugin_args` deprecation notice causes exceptions. Removing use of `plugin_args` fixes all problems. [PR with fix](https://github.com/burnersk/Dancer2-Plugin-Redis/pull/6)

:-1: REST: [Github](https://github.com/perldancer/Dancer2-Plugin-REST) Diff is pretty simple: remove `use Dancer2` ``` --- a/lib/Dancer2/Plugin/REST.pm +++ b/lib/Dancer2/Plugin/REST.pm @@ -6,14 +6,9 @@ use warnings; use Carp 'croak'; -use Dancer2 0.149000_01; use Dancer2::Plugin; use...

On 30/12/15 01:41, Sawyer X wrote: > @SysPete https://github.com/SysPete I fixed the uninitialized warning! > > — > Reply to this email directly or view it on GitHub > https://github.com/PerlDancer/Dancer2/issues/1078#issuecomment-167906412....

So does this mean if the user does: ``` uri_for( '1', { id => 4 } ); ``` and expects something like `http://example.com/1?id=4` they are not going to get what...

Second param can already be a hashref: ``` sub uri_for { my ( $self, $part, $params, $dont_escape ) = @_; ... $uri->query_form($params) if $params; ```

I think I'd prefer a new `named_uri_for` keyword just to be sure weird stuff doesn't happen by accident.

@xsawyerx I just rebased this against current master as I'd really like to see it merged. I'm going to go back over all of the comments to check that all...

Some local test failures, but Travis is busy with maintenance atm. Lots of interesting appveyor failures too. I'll start looking tomorrow.

Removing from milestone since this still needs a huge amount of work.

@veryrusty :+1: for using `+` as a FQ namespace indicator as it follows a pattern used elsewhere. Very happy to see this, thank you!