Daniel Marshall comments

Results 6 comments of


                                            Daniel Marshall

Updated NavigationSystem for 4.20

Just thought I should point out that the ini file doesn't need updating if you were already using 4.20 when changing the navmesh to be dynamic (L298).

Incorrect import for Velen's chosen

Had the same problem with "Shadow Form" and "Power Word: Glory"

<type_traits>: aligned_storage has incorrect alignment defaults

Is it worth creating a vNext/ABI breaking issue template? (I notice a lot fail to mention that note)

<type_traits>: aligned_storage has incorrect alignment defaults

Alright, cool. Nagging it is. --- You could also turn "Checklist For Merging A Pull Request" into "Maintainer Guidelines" with a point to remember to add the note if/when marking...

P3168R2 `std::optional` Range Support

I know C++26 features aren't being accepted at the moment but this should probably be blocked on the outcome of https://wg21.link/P3415

P2821R5 `span::at()`

You should add tests as you've got the condition backwards. You're currently throwing on valid indices.