P2821R5 `span::at()`

Open StephanTLavavej opened this issue 2 years ago • 4 comments

WG21-P2821R5 span::at()

INCREASED feature-test macro; note that WG21-P2833R2 #4177 is intentionally simultaneously updating this value:

#define __cpp_lib_span 202311L

Note: We're focused on implementing the remaining library-only features in C++23. Until that's done, we will NOT be accepting PRs for C++26 features.

Nov 12 '23 22:11 StephanTLavavej

Hi, I'm implementing P2821R5 in my repository. But it seems like I shouldn't create the PR until the remaining library-only features in C++ 23 are done.

Sep 08 '24 04:09 heckerpowered

I'll move this to Investigating for you. Correct, we aren't accepting C++26 PRs yet, although we hope to finish the C++23 library-only features soon.

Sep 09 '24 08:09 StephanTLavavej

You should add tests as you've got the condition backwards. You're currently throwing on valid indices.

Sep 24 '24 07:09 SuperWig

You should add tests as you've got the condition backwards. You're currently throwing on valid indices.

Thanks for the reminder, I'll make it correct when I create the pull request.

Sep 24 '24 07:09 heckerpowered