Sinus
Sinus
This seems like a useful PR, I'd happily write a curl variant for my needs. What's missing for this to be merged? I could think of adding `implements HttpAdapterInterface` to...
How does the proposed change affect error handling, though? Obviously any other HTTP adapter would have to implement their own, but it wouldn't "break" error handling. It just wouldn't improve...
(By the way: your PR won't merge cleanly anymore; there have been changes to the Base_Client constructor definition.)
After incorporating your HttpAdapterInterface into my variant (a cURL adapter), I see what you meant with the exceptions. Well, yes, you'll probably have to catch the GuzzleHttp\Exception exceptions and throw...
Well, good job me, forgot to add the one file core to the idea.
- The image was there just for illustration purposes, probably should've been just part of a comment. - I was undecided on the parsing half-lib. Very well, moving it into...
Time permitting, sure - but I thought I brought it to a workable state already.
Note: most original Sierra AGI games are rather conservative about their PCjr sounds, so they don't play fast vibratos, arpeggios, or other typical chiptune trickery. Hence, the choppiness of the...
Sorry about that merge, it was a clumsy click in GitHub and I didn't realise it would go into the PR. But, frankly, how do I go about it now?...
Issue narrowed down to `yauzl` using an utf8 string as template for CP437-to-Unicode conversion - but the issue remains (or remained): the yauzl module code gets interpreted as single-byte encoding...