BugSack icon indicating copy to clipboard operation
BugSack copied to clipboard
verified publisher icon funkydude

new formatting plugin system, new Compact formatting plugin

Open SinusPi opened this issue 3 years ago • 6 comments

  • added support for formatting plugins, able to modify the display of Message, Stack and Locals.
  • "Compact" formatting plugin included, with an explanatory screenshot.
  • switching of plugins is available in the config panel.

SinusPi avatar Nov 15 '22 02:11 SinusPi

Well, good job me, forgot to add the one file core to the idea.

SinusPi avatar Nov 15 '22 17:11 SinusPi

Nice work! I'll take a proper look at this later but for now I did a quick skim:

  • Remove the image, don't think we need this
  • The hard-embedded kind of half-library code should just be merged into the core addon and not used as a library
  • The new files are missing newlines at the end

funkydude avatar Nov 20 '22 15:11 funkydude

  • The image was there just for illustration purposes, probably should've been just part of a comment.
  • I was undecided on the parsing half-lib. Very well, moving it into the main file space.

SinusPi avatar Nov 20 '22 21:11 SinusPi

Sorry I totally forgot about this. Are you still interested in working on it?

funkydude avatar Jan 28 '23 00:01 funkydude

Time permitting, sure - but I thought I brought it to a workable state already.

SinusPi avatar Jan 28 '23 01:01 SinusPi

as a followup, i grabbed the PR and tested it, changing the formatter dropdown from anything to raw causes an error.

10x Interface/AddOns/BugSack/core.lua:247: bad argument #1 to 'format' (string expected, got nil)

Stack: [string "=[C]"]: in function format' [string "@Interface/AddOns/BugSack/core.lua"]:247: in function FormatError' [string "@Interface/AddOns/BugSack/sack.lua"]:90: in function <Interface/AddOns/BugSack/sack.lua:32> [string "@Interface/AddOns/BugSack/sack.lua"]:128: in function <Interface/AddOns/BugSack/sack.lua:124> [string "=[C]"]: ? [string "=[C]"]: in function UpdateDisplay' [string "@Interface/AddOns/BugSack/config.lua"]:78: in function func' [string "@Interface/SharedXML/UIDropDownMenu.lua"]:1007: in function `UIDropDownMenuButton_OnClick' [string "*UIDropDownMenuTemplates.xml:136_OnClick"]:1: in function <[string "*UIDropDownMenuTemplates.xml:136_OnClick"]:1>

Locals: (*temporary) = "

Stack: %s" (*temporary) = nil (*temporary) = "string expected, got nil"

MyTechnoHunter avatar Apr 17 '23 21:04 MyTechnoHunter